slow-J commented on code in PR #12849:
URL: https://github.com/apache/lucene/pull/12849#discussion_r1408514109
##########
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/util/UnescapedCharSequence.java:
##########
@@ -101,7 +90,7 @@ public String toStringEscaped() {
*/
public String toStringEscaped(char[] enabledChars) {
// TODO: non efficient implementation, refactor this code
Review Comment:
In the Lucene codebase this is only ever called with array of length 2, so I
didn't refactor......
##########
lucene/queryparser/src/java/org/apache/lucene/queryparser/flexible/core/util/UnescapedCharSequence.java:
##########
@@ -101,7 +90,7 @@ public String toStringEscaped() {
*/
public String toStringEscaped(char[] enabledChars) {
// TODO: non efficient implementation, refactor this code
Review Comment:
In the Lucene codebase, this is only ever called with array of length 2, so
I didn't refactor......
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
