javanna commented on PR #12798: URL: https://github.com/apache/lucene/pull/12798#issuecomment-1828210981
With the latest updates, I am not convinced about this change. I think it's great to use TaskExecutor to execute parallel tasks, like you did in #12799, but I am under the impression that this PR takes it a bit too far in terms of responsibilities of TaskExecutor and functionalities it exposes. I woudl be ok with those consumers that deal with futures keeping their current logic that does not depend on TaskExecutor, unless they use TaskExecutor directly to run their futures. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
