slow-J commented on issue #12243: URL: https://github.com/apache/lucene/issues/12243#issuecomment-1824681333
> > I don't think the fact that TermInSetQuery has a Collection ctor should impact this at all. Maybe that should be removed? > > +1 > > It's weird to take both array and Collection when the API is just going to do the obvious conversion that a caller would do? We should somehow be consistent here about such "sugar" APIs. > > But if we are going to pick one, shouldn't it be `Collection` for these two cases, since order does not matter? Taking an array implies that order might be significant, but (I think?) order does not matter for `KeywordField.newSetQuery` nor for `TermInSetQuery` ctor? > > I don't feel strongly though (Collection vs array) ... but I do agree we should be consistent. Thanks Mike, to progress the discussion I opened a PR to remove the `TermInSetQuery` array ctor and change the `KeywordField.newSetQuery` values param to `Collections` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
