dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1400641544
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -248,15 +305,17 @@ public Builder<T>
directAddressingMaxOversizingFactor(float factor) {
/** Creates a new {@link FSTCompiler}. */
public FSTCompiler<T> build() {
- FSTCompiler<T> fstCompiler =
- new FSTCompiler<>(
- inputType,
- suffixRAMLimitMB,
- outputs,
- allowFixedLengthArcs,
- bytesPageBits,
- directAddressingMaxOversizingFactor);
- return fstCompiler;
+ try {
+ return new FSTCompiler<>(
+ inputType,
+ suffixRAMLimitMB,
+ outputs,
+ allowFixedLengthArcs,
+ dataOutput,
+ directAddressingMaxOversizingFactor);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
Review Comment:
Can we defer this? I could add a TODO and do a follow-on PR. The reason is
that it will cause even more diffs and not directly related to this PR main
purpose.
Anyhow I added another PR to propagate this IOException:
https://github.com/apache/lucene/pull/12830. It can be merged in any order
(merging #12830 first means we don't have to add the TODO, but merging this is
more natural)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
