dungba88 commented on PR #12624: URL: https://github.com/apache/lucene/pull/12624#issuecomment-1820094902
> I've taken a look - I think this class should be kept package-private (or even class-private). It is a DataOutput but it serves very specific purposes (with the unusual methods to move the write pointer at random, expand the underlying buffer, etc.). I think that makes sense. Maybe let keep it package-private so that it can be unit-tested? > I also changed the implementation to use OutputStreamDataOutput [1] but it's not any more elegant than written explicitly, so please disregard that suggestion. Thank you for giving it a try! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
