dweiss commented on PR #12824: URL: https://github.com/apache/lucene/pull/12824#issuecomment-1817936062
I don't see the whole picture of where you need it - it would be perhaps better to include this class where it's actually used so that the use context is clear. In general, the less code, the better. Arrays.copyOf is definitely safe inside the JDK. :) It's banned in Lucene because of its problematic semantics - it's not known whether you're trying to "grow" or "shrink" the array, see comments here: https://github.com/apache/lucene/issues/9213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
