jpountz commented on PR #12820: URL: https://github.com/apache/lucene/pull/12820#issuecomment-1815358559
This is an interesting idea. Ideally we would figure out up-front whether it's best to use the graph or not, but I can also imagine that we can't always make the right decision there, so we need the ability to fall back. I wonder if we could make it look a bit nicer API-wise, e.g. could we more generally move the responsibility of tracking which doc IDs have already been collected from the codec to the collector, so that it wouldn't even need changes to the API? I guess that the downside is that it would force us to track this information in the doc ID space, while the codec can do this more efficiently right now by tracking a bit set of vector ordinals. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
