dungba88 commented on code in PR #12624:
URL: https://github.com/apache/lucene/pull/12624#discussion_r1393461923
##########
lucene/core/src/java/org/apache/lucene/util/fst/FSTCompiler.java:
##########
@@ -247,16 +306,14 @@ public Builder<T>
directAddressingMaxOversizingFactor(float factor) {
}
/** Creates a new {@link FSTCompiler}. */
- public FSTCompiler<T> build() {
- FSTCompiler<T> fstCompiler =
- new FSTCompiler<>(
- inputType,
- suffixRAMLimitMB,
- outputs,
- allowFixedLengthArcs,
- bytesPageBits,
- directAddressingMaxOversizingFactor);
- return fstCompiler;
+ public FSTCompiler<T> build() throws IOException {
Review Comment:
This new `throws IOException` causes diff in some other classes. If
preferred I could delay this, and do try-catch here instead to avoid the diffs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
