benwtrent commented on code in PR #12807:
URL: https://github.com/apache/lucene/pull/12807#discussion_r1393328067
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##########
@@ -92,18 +92,8 @@ public final class Lucene99HnswVectorsReader extends
KnnVectorsReader
} catch (Throwable exception) {
Review Comment:
So it was throwing in the `try (ChecksumIndexInput meta =
state.directory.openChecksumInput(metaFileName))`?
Then I was assuming that `CodecUtil.checkFooter(meta, priorE);` would then
throw and the finally `IOUtils.close(flatVectorsReader);` could execute.
But I see now that my `finally` block was nested too deeply :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
