vigyasharma commented on issue #12792: URL: https://github.com/apache/lucene/issues/12792#issuecomment-1808328118
> There will be scenario that developers expect a segment deletion pct to be `delCount / (maxDoc-delCount)` and this accounting seems more realistic than current accounting. I do like the simplicity of `delCount / maxDoc`. In a simple example with `(maxDoc=100, delCount=30)`, it is easier to reason that merges will claim back 30% of the docId space, and roughly similar disk space assuming similarly sized docs. I can use this as a mental model for `setDeletesPctAllowed()` API. Would like to understand the scenarios where people would prefer `delCount / (maxDoc-delCount)` i.e. `(30/(100-30)=42.8%`... Perhaps some examples would help. +1 to improving documentation, we could add a line in the `setDeletesPctAllowed` docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
