benwtrent commented on code in PR #12679:
URL: https://github.com/apache/lucene/pull/12679#discussion_r1389741654


##########
lucene/core/src/java/org/apache/lucene/search/VectorSimilarityCollector.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.lucene.search;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Objects;
+import org.apache.lucene.util.BitSet;
+import org.apache.lucene.util.Bits;
+import org.apache.lucene.util.SparseFixedBitSet;
+
+/**
+ * Perform a similarity-based graph search.
+ *
+ * @lucene.experimental
+ */
+class VectorSimilarityCollector extends AbstractKnnCollector {
+  private static final Bits MATCH_ALL_BITS = new 
Bits.MatchAllBits(Integer.MAX_VALUE);
+
+  private final float traversalSimilarity, resultSimilarity;
+  private final List<ScoreDoc> scoreDocList;
+  private final BitSet visited;
+
+  /**
+   * Perform a similarity-based graph search. All nodes above a {@link 
#traversalSimilarity} are
+   * traversed, and all nodes above a {@link #resultSimilarity} are collected.
+   *
+   * @param traversalSimilarity (lower) similarity score for graph traversal.
+   * @param resultSimilarity (higher) similarity score for result collection.
+   * @param visitLimit limit on number of nodes to visit.
+   * @param maxDoc maximum docid of any node.
+   */
+  public VectorSimilarityCollector(
+      float traversalSimilarity, float resultSimilarity, long visitLimit, int 
maxDoc) {
+    super(1, visitLimit);
+    if (traversalSimilarity > resultSimilarity) {
+      throw new IllegalArgumentException("traversalSimilarity should be <= 
resultSimilarity");
+    }
+    this.traversalSimilarity = traversalSimilarity;
+    this.resultSimilarity = resultSimilarity;
+    this.scoreDocList = new ArrayList<>();
+
+    if (visitLimit == Long.MAX_VALUE) {
+      this.visited = null;
+    } else {
+      this.visited = new SparseFixedBitSet(maxDoc);
+    }

Review Comment:
   The graphSearcher already calls `incVisitedCount` as it occurs. I don't 
think you need to keep track of visited within this collector.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to