uschindler commented on issue #12180: URL: https://github.com/apache/lucene/issues/12180#issuecomment-1804313295
Hi, the commit causes test failures like this from time to time: ``` org.apache.lucene.facet.taxonomy.directory.TestDirectoryTaxonomyReader > testGetPathAndOrdinalsRandomMultithreading FAILED com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=276, name=Thread-152, state=RUNNABLE, group=TGRP-TestDirectoryTaxonomyReader] Caused by: java.lang.IllegalArgumentException: bound must be positive at __randomizedtesting.SeedInfo.seed([EB36AAC7E6947189]:0) at java.base/java.util.Random.nextInt(Random.java:322) at randomizedtesting.runner@2.8.1/com.carrotsearch.randomizedtesting.Xoroshiro128PlusRandom.nextInt(Xoroshiro128PlusRandom.java:73) at randomizedtesting.runner@2.8.1/com.carrotsearch.randomizedtesting.AssertingRandom.nextInt(AssertingRandom.java:87) at org.apache.lucene.facet.taxonomy.directory.TestDirectoryTaxonomyReader.assertGettingPaths(TestDirectoryTaxonomyReader.java:519) at org.apache.lucene.facet.taxonomy.directory.TestDirectoryTaxonomyReader$4.run(TestDirectoryTaxonomyReader.java:721) ``` And hundreds of more threads following. Looks like sometimes the ordinals array is initialized by zero length. The followup random then fail because the upper bound passed to `random#nextInt(limit)` must be `limit>=1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org