rmuir commented on PR #12761: URL: https://github.com/apache/lucene/pull/12761#issuecomment-1793871445
> Looks ok to me. > > Did you check all possible benchmark config/ALG files (not all of them are tested) that the locales in them are correctly for usage as language tag? ``` $ git grep NewLocale conf/collation.alg: -NewLocale(fr) conf/collation.alg: -NewLocale(de) conf/collation.alg: -NewLocale(uk) conf/collation.alg: -NewLocale(en) conf/collation.alg: -NewLocale(fr) conf/collation.alg: -NewLocale(de) conf/collation.alg: -NewLocale(uk) conf/collation.alg: -NewLocale(en) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
