iverase opened a new pull request, #12762: URL: https://github.com/apache/lucene/pull/12762
HeapPointWriter uses a a byte array to hold points on heap. This array is access directly from BKD radix selector to sort points in place. In addition the HeapPointReader uses the array to read the points too. I wanted to check the performance impact of changing this data structure as this array can be very big which plays bad with garbage collector like G1 as the array will be considered humongous. The current structure of HeapPointWriter makes this very difficult. This PR refactor HeapPointWriter by adding methods for in place sorting and changes HeapPointReader to reads points using a functional interface. It encapsulates the internal byte array inside HeapPointWriter. The nice side effect is it removes some code duplication too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
