mikemccand commented on PR #12737: URL: https://github.com/apache/lucene/pull/12737#issuecomment-1793421290
I tested on my now-ancient Zen2 beast3 (nightly benchmark) box (`AMD Ryzen Threadripper 3990X 64-Core Processor`), using JDK 21 (`openjdk full version "21+35"`), with command-line `./gradlew clean; ./gradlew -p lucene/benchmark-jmh assemble; java -jar lucene/benchmark-jmh/build/benchmarks/lucene-benchmark-jmh-10.0.0-SNAPSHOT.jar float -p size=1024`. [An aside: strangely, to test the PR, I normally download and apply the [`.diff`](https://patch-diff.githubusercontent.com/raw/apache/lucene/pull/12737.diff) or [`.patch`](https://patch-diff.githubusercontent.com/raw/apache/lucene/pull/12737.patch) using `patch -p1 < X.diff/patch`, but for this PR there are non-trivial (to me!) conflicts reported by `patch`. So instead I ran the suggested `github` command-line steps for merging, and got a clean applied version of this PR to run the benchy.] `main`: ``` Benchmark (size) Mode Cnt Score Error Units VectorUtilBenchmark.floatCosineScalar 1024 thrpt 15 1.176 ± 0.011 ops/us VectorUtilBenchmark.floatCosineVector 1024 thrpt 75 11.015 ± 0.029 ops/us VectorUtilBenchmark.floatDotProductScalar 1024 thrpt 15 3.870 ± 0.011 ops/us VectorUtilBenchmark.floatDotProductVector 1024 thrpt 75 22.879 ± 0.407 ops/us VectorUtilBenchmark.floatSquareScalar 1024 thrpt 15 2.604 ± 0.023 ops/us VectorUtilBenchmark.floatSquareVector 1024 thrpt 75 21.293 ± 0.289 ops/us ``` PR: ``` Benchmark (size) Mode Cnt Score Error Units VectorUtilBenchmark.floatCosineScalar 1024 thrpt 15 1.553 ± 0.009 ops/us VectorUtilBenchmark.floatCosineVector 1024 thrpt 75 10.995 ± 0.025 ops/us VectorUtilBenchmark.floatDotProductScalar 1024 thrpt 15 4.051 ± 0.029 ops/us VectorUtilBenchmark.floatDotProductVector 1024 thrpt 75 22.887 ± 0.396 ops/us VectorUtilBenchmark.floatSquareScalar 1024 thrpt 15 3.254 ± 0.008 ops/us VectorUtilBenchmark.floatSquareVector 1024 thrpt 75 21.238 ± 0.420 ops/us ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
