stefanvodita commented on issue #12596: URL: https://github.com/apache/lucene/issues/12596#issuecomment-1793273774
What happens with `createRegularPolygon` is very interesting. The smaller the polygon's radius is and the more vertices it has, the smaller the sides are. At some point they get so small, they can't fit on a float. I opened a [PR](https://github.com/apache/lucene/pull/12757) which should fix the issue. For `surpriseMePolygon`, the problem appears when we have a center with large coordinates and a small radius. The radius is too small to register when doing arithmetic with the center's coordinates. I added a retry mechanism. There are other problems that I have to think about more, maybe in a separate PR. For example, what about large coordinates for `createRegularPolygon`? What about the case when the centers are at `FLOAT_MAX`? Then the radius becomes 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
