rmuir commented on code in PR #12754:
URL: https://github.com/apache/lucene/pull/12754#discussion_r1381962437
##########
lucene/core/src/java/org/apache/lucene/util/Constants.java:
##########
@@ -53,28 +53,33 @@ private Constants() {} // can't construct
/** The value of <code>System.getProperty("java.vendor")</code>. */
public static final String JAVA_VENDOR = System.getProperty("java.vendor");
+ /** True iff the Java runtime is a client runtime and C2 compiler is not
enabled */
+ public static final boolean IS_CLIENT_VM =
+ System.getProperty("java.vm.info", "").contains("emulated-client");
+
/** True iff running on a 64bit JVM */
- public static final boolean JRE_IS_64BIT;
+ public static final boolean JRE_IS_64BIT = is64Bit();
+
+ /** true iff we know fast FMA is supported, to deliver less error */
+ public static final boolean HAS_FAST_FMA =
+ (IS_CLIENT_VM == false)
+ && Constants.OS_ARCH.equals("amd64")
+ &&
HotspotVMOptions.get("UseFMA").map(Boolean::valueOf).orElse(false);
Review Comment:
Can we update this with the current logic in the other branch? With the
newer Neoverse cores that support SVE, they "fixed" their FMA to be fast, so we
turn it on there too. It is a good exercise as well since it must check integer
parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
