uschindler commented on PR #888:
URL: https://github.com/apache/lucene/pull/888#issuecomment-1792528482

   Hi @mikemccand,
   I reset the branch to the initial commit (without BytesRefHash & Co. changes 
). Then I merged and pushed.
   I will now try to redo the changes.
   
   In fact, on x86 machines it makes no sense to benchmark it, as the LE byte 
order is already native :-) This PR only helps with architectures like s390x 
that have big endian, as the internals of BytesRefHash would never make it into 
a file format so they can encode their "private data" in native endianness. We 
still randomize the endianness on testing, so we make sure both variants work.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to