jimczi commented on PR #12729: URL: https://github.com/apache/lucene/pull/12729#issuecomment-1792391067
I agree with Adrien that hardcoded formats with a clear strategy are better. We want to avoid exposing a knn format that takes another abstract format. That would be cryptic and difficult to navigate for users. However I think we can reuse existing format as an implementation detail. The `Lucene99HnswScalarQuantizedVectorsFormat ` could be hardcoded to use the `Lucene99ScalarQuantizedVectorsFormat` internally. The fact that we register the format does not mean that we expose the composability to users. In its current form the `FlatVector...` lineage is redundant if it's only to avoid to register the format explicitly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
