mikemccand commented on issue #10309: URL: https://github.com/apache/lucene/issues/10309#issuecomment-1790845238
> * while testing a solution for adding `perReaderTermState` to the current `TermQuery#equals` implementation, I found a test that I believe is not doing anything of what it was designed to do - essentially it was rewritten for an only tangentially related change, and it's been working as no-op since (test is [TestMultiTermQueryRewrites#checkBoosts](https://github.com/apache/lucene-solr/blob/master/lucene/core/src/test/org/apache/lucene/search/TestMultiTermQueryRewrites.java#L215), problematic edit was [this](https://github.com/apache/lucene-solr/commit/30807709e663c35f6760084632407dc1bf76aff7#diff-581d1e68f090e657acc327fc90534c51), missing essential `initialSeekTerm`). Should I fix it as part of my proposal for this or open a new issue? Yikes -- did you ever open a separate issue/PR for this missing `initialSeekTerm`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
