mikemccand commented on code in PR #12433: URL: https://github.com/apache/lucene/pull/12433#discussion_r1380176295
########## lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/Word2VecSynonymFilter.java: ########## @@ -62,14 +65,16 @@ public Word2VecSynonymFilter( TokenStream input, Word2VecSynonymProvider synonymProvider, int maxSynonymsPerTerm, - float minAcceptedSimilarity) { + float minAcceptedSimilarity, + boolean similarityAsBoost) { Review Comment: Should we add a back-compat ctor that doesn't take `similarityAsBoost`, and defaults it to `false` I guess? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org