jpountz commented on PR #1052: URL: https://github.com/apache/lucene/pull/1052#issuecomment-1790599704
+1 I fell a bit into a trap by trying to make long shared prefixes less adversarial. Let's do progress over perfection and start with a simple approach and look into whether/how we can better handle long sequences of shared prefixes better. It still shows a good speedup on `OrdinalMapBenchmark`: main: ``` id: 1401.18461 msec name: 1248.35069 msec country_code: 0.39746 msec time_zone: 0.91389 msec ``` PR: ``` id: 623.27067 msec name: 937.10905 msec country_code: 0.30416 msec time_zone: 0.88108 msec ``` I plan on merging soon if there are no objections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
