ChrisHegarty commented on code in PR #12694: URL: https://github.com/apache/lucene/pull/12694#discussion_r1375318798
########## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java: ########## @@ -352,6 +382,11 @@ private int dotProductBody512(byte[] a, byte[] b, int limit) { // 16-bit multiply: avoid AVX-512 heavy multiply on zmm Vector<Short> va16 = va8.convertShape(B2S, SHORT_SPECIES, 0); Vector<Short> vb16 = vb8.convertShape(B2S, SHORT_SPECIES, 0); + if (unsigned) { Review Comment: If we need to, we can add an option that adds pollution to the profiles. But we kinda already know that it will be bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org