shubhamvishu commented on PR #12427:
URL: https://github.com/apache/lucene/pull/12427#issuecomment-1782977506
@gsmiller I finally got a chance to run the benchmarks for this change.
Below are the results(looks all good to me). Let me know what do you think?
Thanks!
```
TaskQPS baseline StdDevQPS my_modified_version
StdDev Pct diff p-value
AndHighMed 96.52 (6.5%) 95.49
(6.3%) -1.1% ( -12% - 12%) 0.597
LowSpanNear 133.61 (4.7%) 132.45
(4.0%) -0.9% ( -9% - 8%) 0.528
OrHighMed 67.95 (3.2%) 67.37
(4.6%) -0.9% ( -8% - 7%) 0.492
MedSpanNear 5.79 (5.2%) 5.74
(4.2%) -0.8% ( -9% - 8%) 0.573
OrNotHighLow 322.30 (2.3%) 319.70
(2.0%) -0.8% ( -4% - 3%) 0.233
BrowseDateSSDVFacets 0.90 (8.2%) 0.89
(9.4%) -0.8% ( -17% - 18%) 0.773
AndHighLow 355.80 (4.2%) 352.99
(4.1%) -0.8% ( -8% - 7%) 0.550
MedTermDayTaxoFacets 5.85 (6.2%) 5.81
(5.7%) -0.7% ( -11% - 11%) 0.713
OrNotHighMed 222.70 (3.6%) 221.51
(4.0%) -0.5% ( -7% - 7%) 0.657
OrHighNotMed 194.41 (3.6%) 193.40
(3.4%) -0.5% ( -7% - 6%) 0.641
MedPhrase 44.71 (3.1%) 44.50
(3.4%) -0.5% ( -6% - 6%) 0.639
OrNotHighHigh 179.60 (3.7%) 178.85
(3.8%) -0.4% ( -7% - 7%) 0.726
HighSpanNear 8.33 (4.6%) 8.30
(4.1%) -0.4% ( -8% - 8%) 0.765
OrHighNotLow 331.53 (3.8%) 330.15
(3.7%) -0.4% ( -7% - 7%) 0.728
OrHighNotHigh 248.18 (3.5%) 247.20
(3.4%) -0.4% ( -7% - 6%) 0.718
MedIntervalsOrdered 4.66 (4.6%) 4.64
(4.3%) -0.4% ( -8% - 8%) 0.780
OrHighMedDayTaxoFacets 4.39 (3.9%) 4.38
(4.2%) -0.3% ( -8% - 8%) 0.820
OrHighLow 569.67 (2.6%) 568.04
(2.6%) -0.3% ( -5% - 5%) 0.733
LowIntervalsOrdered 2.64 (4.6%) 2.64
(4.6%) -0.2% ( -8% - 9%) 0.899
HighTermTitleBDVSort 5.20 (4.0%) 5.19
(4.1%) -0.2% ( -7% - 8%) 0.895
OrHighHigh 35.47 (4.4%) 35.42
(5.8%) -0.1% ( -9% - 10%) 0.929
BrowseDayOfYearTaxoFacets 3.80 (15.9%) 3.80
(16.0%) -0.1% ( -27% - 37%) 0.984
BrowseDateTaxoFacets 3.78 (15.5%) 3.78
(15.5%) -0.0% ( -26% - 36%) 0.995
AndHighHigh 16.35 (3.6%) 16.35
(7.5%) 0.0% ( -10% - 11%) 0.996
AndHighMedDayTaxoFacets 49.40 (1.6%) 49.41
(1.7%) 0.0% ( -3% - 3%) 0.975
LowPhrase 254.05 (3.6%) 254.16
(4.0%) 0.0% ( -7% - 7%) 0.972
HighPhrase 40.53 (3.1%) 40.56
(3.6%) 0.1% ( -6% - 6%) 0.939
PKLookup 131.32 (2.3%) 131.44
(2.0%) 0.1% ( -4% - 4%) 0.891
BrowseRandomLabelTaxoFacets 3.28 (15.0%) 3.28
(14.8%) 0.1% ( -25% - 35%) 0.983
BrowseMonthTaxoFacets 4.13 (34.7%) 4.13
(34.7%) 0.1% ( -51% - 106%) 0.991
Fuzzy1 65.72 (1.1%) 65.81
(1.2%) 0.1% ( -2% - 2%) 0.714
LowTerm 513.23 (2.9%) 513.99
(2.9%) 0.1% ( -5% - 6%) 0.870
HighIntervalsOrdered 1.62 (5.3%) 1.62
(5.0%) 0.2% ( -9% - 11%) 0.909
BrowseDayOfYearSSDVFacets 3.75 (12.4%) 3.76
(8.6%) 0.2% ( -18% - 24%) 0.956
MedTerm 382.67 (3.7%) 383.49
(3.9%) 0.2% ( -7% - 8%) 0.857
LowSloppyPhrase 12.31 (2.4%) 12.34
(2.1%) 0.2% ( -4% - 4%) 0.754
Respell 36.92 (1.6%) 37.02
(1.6%) 0.3% ( -2% - 3%) 0.617
MedSloppyPhrase 22.87 (3.2%) 22.94
(3.0%) 0.3% ( -5% - 6%) 0.751
HighTerm 251.80 (4.3%) 252.92
(4.6%) 0.4% ( -8% - 9%) 0.752
AndHighHighDayTaxoFacets 7.39 (2.7%) 7.43
(2.6%) 0.5% ( -4% - 5%) 0.571
Fuzzy2 39.80 (1.4%) 40.02
(1.8%) 0.5% ( -2% - 3%) 0.288
HighSloppyPhrase 1.88 (4.3%) 1.89
(4.2%) 0.6% ( -7% - 9%) 0.657
Wildcard 39.56 (3.9%) 39.82
(2.7%) 0.7% ( -5% - 7%) 0.537
Prefix3 77.73 (6.4%) 78.39
(5.8%) 0.8% ( -10% - 13%) 0.663
HighTermMonthSort 2196.21 (3.5%) 2217.20
(3.5%) 1.0% ( -5% - 8%) 0.389
HighTermDayOfYearSort 200.38 (3.6%) 203.21
(3.2%) 1.4% ( -5% - 8%) 0.186
BrowseMonthSSDVFacets 4.46 (13.1%) 4.53
(9.4%) 1.5% ( -18% - 27%) 0.687
BrowseRandomLabelSSDVFacets 2.68 (7.7%) 2.73
(4.5%) 1.6% ( -9% - 14%) 0.421
IntNRQ 17.08 (4.8%) 17.41
(7.4%) 1.9% ( -9% - 14%) 0.335
TermDTSort 102.14 (2.9%) 104.31
(5.5%) 2.1% ( -6% - 10%) 0.127
HighTermTitleSort 38.07 (11.1%) 39.53
(9.0%) 3.8% ( -14% - 26%) 0.228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
