zhaih commented on PR #12660: URL: https://github.com/apache/lucene/pull/12660#issuecomment-1778626211
@msokolov @benwtrent I removed almost all `nocommit` (except the renaming one) and rebased to main, please take a look if you have time. @benwtrent Please check whether the rebase and modification, especially the scalar quantized part is done correctly. I did it according to my understanding but that is not necessarily correct :) I'll do another round of benchmark run tomorrow to make sure things are still intact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
