jpountz commented on code in PR #12549:
URL: https://github.com/apache/lucene/pull/12549#discussion_r1322592471
##########
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##########
@@ -518,11 +518,10 @@ public void testFlushWithNoMerging() throws IOException {
doc.add(newField("field", "aaa", customType));
for (int i = 0; i < 19; i++) writer.addDocument(doc);
writer.flush(false, true);
- writer.close();
- SegmentInfos sis = SegmentInfos.readLatestCommit(dir);
// Since we flushed w/o allowing merging we should now
// have 10 segments
- assertEquals(10, sis.size());
+ assertEquals(10, writer.getSegmentCount());
+ writer.close();
Review Comment:
Note to reviewers: this test started failing because `writer.close()` now
triggers merges because of the change. So I changed the test to check the
number of segments after the `flush` call but before the `close` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
