javanna commented on code in PR #12718:
URL: https://github.com/apache/lucene/pull/12718#discussion_r1369871845
##########
lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java:
##########
@@ -115,10 +115,10 @@ public class IndexSearcher {
protected final List<LeafReaderContext> leafContexts;
/**
- * used with executor - LeafSlice supplier where each slice holds a set of
leafs executed within
+ * Used with executor - LeafSlice supplier where each slice holds a set of
leafs executed within
* one thread. We are caching it instead of creating it eagerly to avoid
calling a protected
- * method from constructor, which is a bad practice. This is {@code null} if
no executor is
- * provided
+ * method from constructor, which is a bad practice. Always non-null,
regardless of whether an
+ * executor is provided or not.
Review Comment:
the behaviour here has recently changed, but the docs were out of date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
