mikemccand commented on code in PR #12633:
URL: https://github.com/apache/lucene/pull/12633#discussion_r1366910269
##########
lucene/core/src/java/org/apache/lucene/util/fst/NodeHash.java:
##########
@@ -99,20 +184,18 @@ private long hash(FSTCompiler.UnCompiledNode<T> node) {
h += 17;
}
}
- // System.out.println(" ret " + (h&Integer.MAX_VALUE));
+
Review Comment:
> Do we need to mask with Long.MAX_VALUE below, since we mask anyway with
the table mask?
You're right, this is pointless -- I'll remove from both hash functions --
then we preserve that top (sign) bit for this following change:
> Instead, we should multiply with the gold constant BitMixer#PHI_C64 (make
it public).
Whoa, this sounds awesome! I was wondering if we could improve the
simplistic hashing here ... I'll open a spinoff issue with this idea. Sounds
like a low hanging hashing fruit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
