dungba88 commented on code in PR #12698: URL: https://github.com/apache/lucene/pull/12698#discussion_r1365657190
########## lucene/CHANGES.txt: ########## @@ -325,6 +325,8 @@ Bug Fixes * GITHUB#12571: Fix HNSW graph read bug when built with excessive connections. (Ben Trent). +* GITHUB#12698: Fix index out of bounds bug when saving FSTStore-backed FST with different DataOutput for metadata Review Comment: > Do we really never, in Lucene today, write the FST and its metadata to different files? It seems we do, in those `LuceneXXBlockTreeTermsWriter.TermsWriter.finish()`. But they had used the BytesStore-backed FST (FST on-the-fly), so it would not cause the issue either. I think this issue is to make the two branches more consistent and help to simplify the consolidation of BytesStore and FSTStore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
