shubhamvishu commented on code in PR #12653: URL: https://github.com/apache/lucene/pull/12653#discussion_r1365184008
########## lucene/core/src/java/org/apache/lucene/codecs/MultiLevelSkipListWriter.java: ########## @@ -130,12 +129,14 @@ public void bufferSkip(int df) throws IOException { assert df % skipInterval == 0; int numLevels = 1; - df /= skipInterval; - - // determine max level - while ((df % skipMultiplier) == 0 && numLevels < numberOfSkipLevels) { + if (df % windowLength == 0) { Review Comment: Yes, exactly! I'll add a comment to mention this. The ascii art is taken from this class javadocs(top of this file) itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org