mikemccand commented on PR #12633: URL: https://github.com/apache/lucene/pull/12633#issuecomment-1768373972
OK, I switched the accounting to approximate RAM usage of the `NodeHash`, which is more intuitive for users. It behaves monodically / smoothly: as you give more RAM for the suffixes stored in `NodeHash`, the resulting fst is smaller:  If you pass `Double.POSITIVE_INFINITY` (or any sufficiently large number) then we will store all suffixes and the resulting FST is minimal. I think this is nearly ready -- I'll next clean up the remaining `nocommit`s, and downgrade some to `TODO`s. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
