gf2121 commented on PR #12557: URL: https://github.com/apache/lucene/pull/12557#issuecomment-1768169254
Thanks @easyice ! As we are exposing API like `softUpdateDocument(Term term, Iterable<? extends IndexableField> doc, Field... softDeletes)`. We cannot guarantee that all soft delete fields have the same value 1 in Lucene. This patch looks more reasonable as we remove this assertion. But I am not sure if it is the right answer to touch the `NumericDocValues` interface for this scene, Let's see what other people think :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
