dungba88 opened a new pull request, #12691:
URL: https://github.com/apache/lucene/pull/12691

   ### Description
   
   This change will make the transition to off-heap FST writing easier. The 
idea is to only build the FST after the end of the process (when calling 
`compile()`).
   
   -  Consolidate the FSTStore and BytesStore in FST. The two are similar, 
except that FSTStore has an `init()` method, which is not needed for 
BytesStore. Thus I extracted the common methods to FSTReader (maybe a bad 
name). FST no longer needs to have if-else conditional logics to choose between 
the two.
   - Remove all write methods out of FST so that it will be completely 
read-only. These methods are only used by FSTCompiler when constructing FST.
   - Decouple NodeHash and FST by extract the functionality into FSTTraversal 
(again, could be bad name). The FST will only be created after completion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to