kaivalnp commented on code in PR #12679: URL: https://github.com/apache/lucene/pull/12679#discussion_r1362476143
########## lucene/core/src/java/org/apache/lucene/search/RnnCollector.java: ########## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.lucene.search; + +import java.util.ArrayList; +import java.util.List; + +/** + * A collector that performs radius-based vector searches. All vectors within an outer radius are + * traversed, and those within an inner radius are collected. + * + * @lucene.experimental + */ +public class RnnCollector extends AbstractKnnCollector { + private final float traversalThreshold, resultThreshold; + private final List<ScoreDoc> scoreDocList; + + /** + * Performs radius-based vector searches. + * + * @param traversalThreshold similarity score corresponding to outer radius of graph traversal. + * @param resultThreshold similarity score corresponding to inner radius of result collection. + * @param visitLimit limit of graph nodes to visit. + */ + public RnnCollector(float traversalThreshold, float resultThreshold, long visitLimit) { + super(Integer.MAX_VALUE, visitLimit); + assert traversalThreshold <= resultThreshold; + this.traversalThreshold = traversalThreshold; + this.resultThreshold = resultThreshold; + this.scoreDocList = new ArrayList<>(); + } + + @Override + public boolean collect(int docId, float similarity) { + if (similarity >= resultThreshold) { + return scoreDocList.add(new ScoreDoc(docId, similarity)); + } + return false; + } + + @Override + public float minCompetitiveSimilarity() { + return traversalThreshold; + } + + @Override + // This does not return results in a sorted order to prevent unnecessary calculations (because we + // do not want to maintain the topK) Review Comment: Moved to more suitable places -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
