shubhamvishu commented on code in PR #12682: URL: https://github.com/apache/lucene/pull/12682#discussion_r1361736510
########## lucene/core/src/java/org/apache/lucene/search/ReqOptSumScorer.java: ########## @@ -266,7 +265,7 @@ public float score() throws IOException { score += optScorer.score(); } - return score; + return (float) score; Review Comment: Makes sense to me! I think in that case we should remove the TODO as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org