rmuir commented on PR #12681: URL: https://github.com/apache/lucene/pull/12681#issuecomment-1763402811
> > ok, all done. "asfgit" can do proper merge commit :) thanks @uschindler ! > > The only downside is that backporting gets harder. So squashed PRs are easier to handle in that regard. Not if u use an explicit merge commit. You can backport entire PRs that way with a single `git cherry-pick -m`. Your problem is fast forwards. I don't want those, I argue for merge commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
