ChrisHegarty commented on code in PR #12681: URL: https://github.com/apache/lucene/pull/12681#discussion_r1359857545
########## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java: ########## @@ -16,165 +16,155 @@ */ package org.apache.lucene.internal.vectorization; +import static jdk.incubator.vector.VectorOperators.ADD; +import static jdk.incubator.vector.VectorOperators.B2I; +import static jdk.incubator.vector.VectorOperators.B2S; +import static jdk.incubator.vector.VectorOperators.S2I; + import jdk.incubator.vector.ByteVector; import jdk.incubator.vector.FloatVector; import jdk.incubator.vector.IntVector; import jdk.incubator.vector.ShortVector; import jdk.incubator.vector.Vector; -import jdk.incubator.vector.VectorOperators; import jdk.incubator.vector.VectorShape; import jdk.incubator.vector.VectorSpecies; +import org.apache.lucene.util.Constants; +/** + * VectorUtil methods implemented with Panama incubating vector API. + * + * <p>Supports two system properties for correctness testing purposes only: + * + * <ul> + * <li>tests.vectorsize (int) + * <li>tests.forceintegervectors (boolean) Review Comment: This is great. I love the integrated benchmarks, and now this improved testing support. It'll really help the maintainability of this code going forward. 👍 ########## lucene/core/src/java20/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java: ########## @@ -16,165 +16,155 @@ */ package org.apache.lucene.internal.vectorization; +import static jdk.incubator.vector.VectorOperators.ADD; +import static jdk.incubator.vector.VectorOperators.B2I; +import static jdk.incubator.vector.VectorOperators.B2S; +import static jdk.incubator.vector.VectorOperators.S2I; + import jdk.incubator.vector.ByteVector; import jdk.incubator.vector.FloatVector; import jdk.incubator.vector.IntVector; import jdk.incubator.vector.ShortVector; import jdk.incubator.vector.Vector; -import jdk.incubator.vector.VectorOperators; import jdk.incubator.vector.VectorShape; import jdk.incubator.vector.VectorSpecies; +import org.apache.lucene.util.Constants; +/** + * VectorUtil methods implemented with Panama incubating vector API. + * + * <p>Supports two system properties for correctness testing purposes only: + * + * <ul> + * <li>tests.vectorsize (int) + * <li>tests.forceintegervectors (boolean) Review Comment: This is great. I love the integrated benchmarks, and now this improved testing support. It'll really help the maintainability of this code going forward. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
