uschindler commented on code in PR #12677:
URL: https://github.com/apache/lucene/pull/12677#discussion_r1359204492
##########
lucene/core/src/java/org/apache/lucene/internal/vectorization/VectorizationProvider.java:
##########
@@ -120,24 +122,22 @@ static VectorizationProvider lookup(boolean testMode) {
} else if (runtimeVersion >= 22) {
LOG.warning(
"You are running with Java 22 or later. To make full use of the
Vector API, please update Apache Lucene.");
- } else if (vectorModulePresentAndReadable()) {
+ } else if (vectorModulePresent(Objects::equals)) {
Review Comment:
Actually I fully agree with the problem. In the original code the condintion
added the reads unconditionally. This was a good hack, but it allowed incorrect
use (as seen in #12676).
Maybe it is better to move the addReads to the caller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
