gf2121 commented on code in PR #12642:
URL: https://github.com/apache/lucene/pull/12642#discussion_r1351726366
##########
lucene/facet/src/test/org/apache/lucene/facet/TestDrillSideways.java:
##########
@@ -1490,7 +1542,22 @@ public List<DocAndScore>
reduce(Collection<SimpleCollector> collectors) {
.collect(Collectors.toList());
}
}
- ;
+
+ private static class FinishOnceLeafCollector implements LeafCollector {
+ boolean finished;
+
+ @Override
+ public void setScorer(Scorable scorer) throws IOException {}
+
+ @Override
+ public void collect(int doc) throws IOException {}
+
+ @Override
+ public void finish() throws IOException {
+ assertFalse(finished);
Review Comment:
Maybe assert to make sure this method get called?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
