gf2121 commented on PR #12632: URL: https://github.com/apache/lucene/pull/12632#issuecomment-1753077559
I rerun on java 21, `squareDistanceNewNew` looks faster: ``` openjdk version "21" 2023-09-19 OpenJDK Runtime Environment (build 21+35-2513) OpenJDK 64-Bit Server VM (build 21+35-2513, mixed mode, sharing) ``` ``` Benchmark (size) Mode Cnt Score Error Units BinaryCosineBenchmark.cosineDistanceNew 1024 thrpt 5 5.691 ± 0.014 ops/us BinaryCosineBenchmark.cosineDistanceNewNew 1024 thrpt 5 4.908 ± 0.017 ops/us BinaryCosineBenchmark.cosineDistanceOld 1024 thrpt 5 0.830 ± 0.003 ops/us BinaryDotProductBenchmark.dotProductNew 1024 thrpt 5 11.649 ± 0.006 ops/us BinaryDotProductBenchmark.dotProductNewNew 1024 thrpt 5 9.636 ± 0.005 ops/us BinaryDotProductBenchmark.dotProductOld 1024 thrpt 5 1.940 ± 0.013 ops/us BinarySquareBenchmark.squareDistanceNew 1024 thrpt 5 8.143 ± 0.034 ops/us BinarySquareBenchmark.squareDistanceNewNew 1024 thrpt 5 9.410 ± 0.026 ops/us BinarySquareBenchmark.squareDistanceOld 1024 thrpt 5 1.651 ± 0.045 ops/us ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org