gf2121 commented on code in PR #12631:
URL: https://github.com/apache/lucene/pull/12631#discussion_r1349705693
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/Lucene90BlockTreeTermsReader.java:
##########
@@ -81,8 +81,11 @@ public final class Lucene90BlockTreeTermsReader extends
FieldsProducer {
/** Initial terms format. */
public static final int VERSION_START = 0;
+ /** Version that uses MSB VLong encoded output */
+ public static final int VERSION_MSB_VLONG_OUTPUT = 1;
+
/** Current terms format. */
- public static final int VERSION_CURRENT = VERSION_START;
+ public static final int VERSION_CURRENT = VERSION_MSB_VLONG_OUTPUT;
Review Comment:
I wrote some comments on `VERSION_MSB_VLONG_OUTPUT`. I prefer to leave
comments there, as `VERSION_CURRENT` could probably link to other version in
feature. WDYT?
Issue added :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
