benwtrent commented on PR #12590: URL: https://github.com/apache/lucene/pull/12590#issuecomment-1737897805
> Overriding rewrite (first calling super.rewrite and looking at the rewritten Query) I would say don't call `super.rewrite` and just copy paste things. Or use a collector. My main concern is that we are adding yet another extension point for "partial control" when we already have that with the rewrite or something even more complex with the collector. It would be very easy to do the wrong thing by allowing sub-classes to override this method for yet another avenue of customization. It seems to me we have enough extension points no? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
