uschindler commented on code in PR #12600:
URL: https://github.com/apache/lucene/pull/12600#discussion_r1338741133
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -290,6 +312,23 @@ public byte readByte(long pos) throws IOException {
}
}
+ @Override
+ public void readBytes(long pos, byte[] b, int offset, int len) throws
IOException {
+ try {
+ if (true) {
+ throw new IOException("not implemented");
Review Comment:
Don't be afraid by this test, but it is one of the most important IO tests
in Lucene. If you break mmap, it will detect it. 😜
##########
lucene/core/src/java21/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -290,6 +312,23 @@ public byte readByte(long pos) throws IOException {
}
}
+ @Override
+ public void readBytes(long pos, byte[] b, int offset, int len) throws
IOException {
+ try {
+ if (true) {
+ throw new IOException("not implemented");
Review Comment:
Don't be afraid by this test, but it is one of the most important IO tests
in Lucene. If you break mmap, it will detect it. 😜
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
