s1monw commented on PR #12595: URL: https://github.com/apache/lucene/pull/12595#issuecomment-1737068633
@jpountz I added a simplified version of your idea that applies deletes if they consume more RAM than the DWPT we are flushing. The applyAllDeletes() only has an impact if the `FlushControl` has the flag set. Which means it's not always applied. Now, I think if we do round robin or whatever is using more ram we need to rename the method. Which I am ok with but freeing more ram as a side effect we could do too. Maybe add an overload with a boolean? not sure it's necessary... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org