iverase commented on PR #12594: URL: https://github.com/apache/lucene/pull/12594#issuecomment-1736975225
> One suggestion: given that ByteBuffersDataInput already has a size method, why not name the new interface method size as well? The two terms are more or less interchangeable, and that way you don't need to do all the deprecations. Because IndexInput already defines a method called `length`, so adding a `size` method means that all the IndexInput that implements RandomAccessInput (which there are a few) will have a size and a length method which looks less ideal. But if folks thinks otherwise I don't feel strongly about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
