romseygeek commented on PR #12594: URL: https://github.com/apache/lucene/pull/12594#issuecomment-1736960788
I think it's fine to add simple methods to interfaces like this in point releases. Extending RandomAccessInput would be a pretty expert use of lucene. One suggestion: given that `ByteBuffersDataInput` already has a `size` method, why not name the new interface method `size` as well? The two terms are more or less interchangeable, and that way you don't need to do all the deprecations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
