gf2121 commented on code in PR #12573:
URL: https://github.com/apache/lucene/pull/12573#discussion_r1338004334
##########
lucene/core/src/java/org/apache/lucene/index/BufferedUpdates.java:
##########
@@ -139,15 +131,11 @@ public void addTerm(Term term, int docIDUpto) {
return;
}
- deleteTerms.put(term, Integer.valueOf(docIDUpto));
- // note that if current != null then it means there's already a buffered
+ deleteTerms.put(term, docIDUpto);
+ // note that if current != -1 then it means there's already a buffered
// delete on that term, therefore we seem to over-count. this over-counting
// is done to respect IndexWriterConfig.setMaxBufferedDeleteTerms.
Review Comment:
@jpountz I raised https://github.com/apache/lucene/pull/12586 to clean this
up.
BTW, the fancy radix sort is really efficient for most cases in my
benchmark. I tried to introduce it to some other places like
https://github.com/apache/lucene/pull/12587,
https://github.com/apache/lucene/pull/12591. It would be great if you could
take a look at it when you have time. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
