iverase commented on code in PR #12528:
URL: https://github.com/apache/lucene/pull/12528#discussion_r1333318922
##########
lucene/core/src/java/org/apache/lucene/util/bkd/BKDWriter.java:
##########
@@ -1305,6 +1305,7 @@ private void writeLeafBlockPackedValues(
}
if (lowCardinalityCost <= highCardinalityCost) {
out.writeByte((byte) -2);
+ out.writeByte((byte) sortedDim);
Review Comment:
I am a bit confused as this change seems to target leaves with few values
which my intuition says, they are the ones which benefit less from this change.
I think I need to understand better the use case to understand this change and
why this is improving high cardinality use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
