romseygeek commented on code in PR #12581: URL: https://github.com/apache/lucene/pull/12581#discussion_r1333208421
########## lucene/core/src/java/org/apache/lucene/codecs/StoredFieldsWriter.java: ########## @@ -182,6 +190,11 @@ public MergeVisitor(MergeState mergeState, int readerIndex) { } } + @Override + public void binaryField(FieldInfo fieldInfo, DataInput value, int length) throws IOException { + writeField(remap(fieldInfo), value, length); + } + @Override public void binaryField(FieldInfo fieldInfo, byte[] value) throws IOException { // TODO: can we avoid new BR here? Review Comment: Does this ever get called now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org