uschindler commented on code in PR #12183: URL: https://github.com/apache/lucene/pull/12183#discussion_r1333200020
########## lucene/core/src/java/org/apache/lucene/index/TermStates.java: ########## @@ -211,4 +244,40 @@ public String toString() { return sb.toString(); } + + /** Wrapper over TermState, ordinal value, term doc frequency and total term frequency */ Review Comment: Lucene main (Future Lucene 10.x) will use minimum Java 17. branch_9x (For Lucene 9.x) uses Java 11. So record is fine in Lucene Main branch but requires additional work when backporting changes. But at some point we should use records for this type of classes. This would be a good start. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org